Skip to content

While start the shim fail, ensure the socket file has been remove #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

While start the shim fail, ensure the socket file has been remove #366

wants to merge 1 commit into from

Conversation

@jokemanfire
Copy link
Member

@jokemanfire jokemanfire commented Jan 20, 2025

Discovered socket file leak when set_cgroup_ond_oom_store execution failed

@github-actions github-actions bot added the C-shim Containerd shim label Jan 20, 2025
@jokemanfire
Copy link
Member Author

jokemanfire commented Jan 21, 2025

Some fail I have found , while stdin can't parse
"FATA[0001] run pod sandbox: rpc error: code = Unknown desc = failed to start sandbox "b09ff5e143f7f482d71737bd637151cec607d1908c88286552ab740386a7e928": failed to create containerd task: failed to start shim: start failed: io.containerd.runc.v2-rs: Other("add task to cgroup: unable to write to a control group file /sys/fs/cgroup/blkio/BinaryName = ''\nCriuImagePath = ''\nCriuPath = ''\nCriuWorkPath = ''\nIoGid = 0\nIoUid = 0\nNoNewKeyring = false\nNoPivotRoot = false\nRoot = ''\nShimCgroup = ''\nSystemdCgroup = false\n/cgroup.procs, value [CREATE FILE] caused by: Os { code: 2, kind: NotFound, message: "No such file or directory" }"

@jokemanfire jokemanfire mentioned this pull request Jan 22, 2025
Closed
@jokemanfire jokemanfire force-pushed the io branch 2 times, most recently from 993cc51 to a976e50 Compare February 5, 2025 03:17
@github-actions github-actions bot added the C-shim-protos Shim protos label Feb 5, 2025
@jokemanfire jokemanfire force-pushed the io branch 2 times, most recently from 1dc908e to d9050c3 Compare February 5, 2025 06:14
@github-actions github-actions bot removed the C-shim-protos Shim protos label Feb 5, 2025
mxpv
mxpv reviewed Feb 20, 2025
View reviewed changes
@jokemanfire
While start the shim fail, ensure the socket file has been remove
f56a709 
Discovered socket file leak when set_cgroup_ond_oom_store execution failed.

Signed-off-by: jokemanfire <[email protected]>
@jokemanfire
Copy link
Member Author

jokemanfire commented Mar 14, 2025

@mxpv hi, could we fix this bug now?

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Aug 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 6, 2025

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv left review comments

Assignees

No one assigned

Labels

C-shim Containerd shim Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jokemanfire @mxpv